Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions from axios library result in Unhandled rejection #3343

Open
sflanker opened this issue Sep 19, 2024 · 3 comments
Open

Exceptions from axios library result in Unhandled rejection #3343

sflanker opened this issue Sep 19, 2024 · 3 comments

Comments

@sflanker
Copy link

Unhandled exceptions from the axios library result in the following (even though all promises are properly awaited):

Unhandled rejection in example.test.js

  DOMException {}

Whereas I would expect something like

  axios test

  Rejected promise returned by test. Reason:

  Error {
    ...
  }

Root Cause & Suggesion

This is happening because AVA sends transmits message about events like test failure due to exceptions being raised via a channel that requires serialization, and apparently these axios exceptions are not serializable. It would be nice if the outcome were less bad in this scenario. I can understand is isn't going to be possible to provide the same fidelity in this scenario, but it would be nice if the serialization issue could be caught, and instead of sending the full error object, just send an abbreviation (like the message and stack trace, possibly with some kind of warning that serialization of the original error was not possible). As it is the outcome is extremely hard to debug.

Reproducible example (run this test, with no special config):

import test from "ava";
import axios from "axios";
async function notGood() {
    const res = await axios.post("http://nothing/bork");
    return res.status;
}
test("axios test", async (t) => {
    const val = await notGood();
    t.truthy(val);
});

Versions

    "ava": "^6.1.3",
    "axios": "^1.7.7",
@deldrid1
Copy link

+1 for this getting fixed!

@thoughtsunificator
Copy link
Contributor

thoughtsunificator commented Nov 24, 2024

Same thing happens in [email protected] with jsdom:

import ava from "ava"
import jsdom from "jsdom"

ava("test", (test) => {
	const { JSDOM } = jsdom
	const dom = new JSDOM()
	dom.window.document.querySelector("<bar")
	test.pass()
})
Output

✘ [fail]: test Rejected promise returned by test

test

Rejected promise returned by test. Reason:

DOMException {}

Error
at file:///home/user/playground/ava-issues-3343/node_modules/ava/lib/test.js:604:28
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

1 test failed

Looks like node test runner is also swallowing the error and the output is even worse as we simply get a {}.

@illarionvk
Copy link

I'm experiencing the same issue with JSDOM, as @thoughtsunificator demonstrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants