Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The watch mode does not work in v6 #3270

Closed
aristov opened this issue Dec 5, 2023 · 4 comments · Fixed by #3273
Closed

The watch mode does not work in v6 #3270

aristov opened this issue Dec 5, 2023 · 4 comments · Fixed by #3273
Labels
bug current functionality does not work as desired

Comments

@aristov
Copy link

aristov commented Dec 5, 2023

I'm trying to run AVA in watch mode:

npx ava --watch

But I got this error:

file:///Users/aristov/workspace/jste/node_modules/ava/lib/cli.js:525
			signal: abortController.signal,
			                        ^

TypeError: Cannot read properties of undefined (reading 'signal')
    at loadCli (file:///Users/aristov/workspace/jste/node_modules/ava/lib/cli.js:525:28)

Node.js v20.6.1

npx ava works normally.

This bug is only related to version 6.0.0.
@aristov aristov changed the title The watch mode does not work The watch mode does not work in v6 Dec 5, 2023
@novemberborn
Copy link
Member

AVA 6 requires 20.8, can't check right now but that language feature may not be available in 20.6.

@kjellmorten
Copy link

kjellmorten commented Dec 6, 2023 •
edited
Loading

I got the same error with node v20.10.0.

@novemberborn novemberborn added bug current functionality does not work as desired and removed needs triage labels Dec 6, 2023
@novemberborn
Copy link
Member

Whelp, that's what happens when you don't do beta releases 😊

@novemberborn novemberborn mentioned this issue Dec 6, 2023
Merged
novemberborn added a commit that referenced this issue Dec 6, 2023
@novemberborn
Ensure watch mode works outside of its integration tests
029e95a 
Somewhere between developing the watch mode and adding test coverage, a mechanism was introduced to control watch mode in its integration tests. Ironically watch mode relied on this mechanism and no longer worked in actual use.

Fixes #3270
novemberborn added a commit that referenced this issue Dec 6, 2023
@novemberborn
Ensure watch mode works outside of its integration tests
32f282f 
Somewhere between developing the watch mode and adding test coverage, a mechanism was introduced to control watch mode in its integration tests. Ironically watch mode relied on this mechanism and no longer worked in actual use.

Fixes #3270
@novemberborn
Copy link
Member

Fixed in 6.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug current functionality does not work as desired
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure watch mode works outside of its integration tests avajs/ava
3 participants
@novemberborn @kjellmorten @aristov