-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify failure output #1072
Comments
I can take care of this as I've worked with the reporters before. |
Hi, would you mind if i tackle this issue? However, when i run this test i get the following outout: ❯ ./cli.js ava.test.js
1 failed
returns true when happy
Error: unicorn
Test.t [as fn] (ava.test.js:4:11) My output I'm using
Maybe the output from the errorstack has changed in node v7? Responsible for the output: |
Sure, no problem! Give it a try :D There must've been some changes in 7, I haven't looked yet. Here's the Node 7 changelog. |
@ntwcklng We always appreciate help, but @vdemedes is currently doing a big rewrite of the output, so this would conflict. I would ask you to wait until that work is done or try another issue :) |
Okay thanks, i will have a look.
|
Hi there, is this still valid? |
Only partly. The current output looks like:
As you can see, the test file and line are shown twice. I think we could simplify it to not show the stack trace if it's only the test function. @avajs/core Thoughts? |
👍 |
Can I take this as the issue? |
@LasaleFamine Yes :) |
I have a question. Is this related to |
@LasaleFamine Yes, the |
Well, I need some ideas to a good and "self-explained" check. I will make a PR soon though I'm still in WIP. |
With:
It currently outputs:
I think we should simplify it to:
So users can quickly see where the error came from.
Test.fn
doesn't have any value to the user.This also applies to the verbose reporter (
$ ava --verbose
).We could also use https://github.com/sindresorhus/ansi-escapes#itermsetcwdpath to make the path clickable on iTerm.
The text was updated successfully, but these errors were encountered: