From aa9af574b47972bb9b7430114491bb6a9c0982c2 Mon Sep 17 00:00:00 2001 From: Rob Bygrave Date: Tue, 26 Nov 2024 20:23:04 +1300 Subject: [PATCH] Revert RoutingFilter use of try-with-resources --- avaje-jex/src/main/java/io/avaje/jex/jdk/RoutingFilter.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/avaje-jex/src/main/java/io/avaje/jex/jdk/RoutingFilter.java b/avaje-jex/src/main/java/io/avaje/jex/jdk/RoutingFilter.java index 47ad2d2c..dd01ba7f 100644 --- a/avaje-jex/src/main/java/io/avaje/jex/jdk/RoutingFilter.java +++ b/avaje-jex/src/main/java/io/avaje/jex/jdk/RoutingFilter.java @@ -37,7 +37,7 @@ public void doFilter(HttpExchange exchange, Filter.Chain chain) { if (route == null) { var ctx = new JdkContext(mgr, exchange, uri, Set.of()); routes.inc(); - try (exchange) { + try { processNoRoute(ctx, uri, routeType); exchange.setAttribute("JdkContext", ctx); chain.doFilter(exchange); @@ -46,10 +46,11 @@ public void doFilter(HttpExchange exchange, Filter.Chain chain) { handleException(ctx, e); } finally { routes.dec(); + exchange.close(); } } else { route.inc(); - try (exchange) { + try { final Map params = route.pathParams(uri); JdkContext ctx = new JdkContext(mgr, exchange, route.matchPath(), params, route.roles()); try { @@ -64,6 +65,7 @@ public void doFilter(HttpExchange exchange, Filter.Chain chain) { } } finally { route.dec(); + exchange.close(); } } }