fix warp event packing #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 4, 2023
Closed
ceyonur
force-pushed
the
fix-warp-event-packing
branch
from
b442ced
to
d4a5199
Compare
ceyonur
force-pushed
the
warp-event-hh-tests
branch
from
da41f9b
to
f1f6b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #924
Why this should be merged
Fixes the event packing for data for
SendWarpMessage.Fixes: #894
How this works
Uses
abipackagePackEvent/UnpackIntoInterfacefunctions to properly pack/unpack messages for event data.How this was tested
Fixes failing e2e tests. adds new UT tests.