Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Message ID from SendWarpMessage #925

Closed
ceyonur opened this issue Sep 29, 2023 · 0 comments · Fixed by #930
Closed

Return Message ID from SendWarpMessage #925

ceyonur opened this issue Sep 29, 2023 · 0 comments · Fixed by #930
Assignees
Labels
Milestone

Comments

@ceyonur
Copy link
Collaborator

ceyonur commented Sep 29, 2023

Currently we don't return anything from SendWarpMessage function as an output. This seems a less weird if it successfully sends a message. We can return the message ID.

Also after #920, we can put this message ID in event for an easier filter for subscribers. Without #920 we won't be able to put this to topics because maximum 3 (+ event ID) topic are supported.

@ceyonur ceyonur added the bug Something isn't working label Sep 29, 2023
@ceyonur ceyonur added this to the v0.5.7 milestone Sep 29, 2023
@ceyonur ceyonur self-assigned this Sep 29, 2023
@ceyonur ceyonur added this to EVM Sep 29, 2023
@github-project-automation github-project-automation bot moved this to Backlog 🗄 in EVM Sep 29, 2023
@ceyonur ceyonur added warp and removed bug Something isn't working labels Sep 29, 2023
@ceyonur ceyonur linked a pull request Oct 4, 2023 that will close this issue
@ceyonur ceyonur removed a link to a pull request Oct 4, 2023
@github-project-automation github-project-automation bot moved this from Backlog 🗄 to Done ✅ in EVM Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant