Store transactions in nanoBlocks
#136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
patrick-ogrady
commented
Apr 7, 2023
patrick-ogrady
commented
Apr 7, 2023
vm/resolutions.go
Outdated
| @@ -182,6 +182,14 @@ func (vm *VM) processAcceptedBlocks() { | |||
| vm.warpManager.GatherSignatures(context.TODO(), tx.ID(), result.WarpMessage.Bytes()) | |||
| } | |||
|
|
|||
| // Update chunk store | |||
| for _, chunk := range b.FetchedChunks { | |||
| if err := vm.StoreChunk(chunk); err != nil { | |||
There was a problem hiding this comment.
TODO: add chunk cache
patrick-ogrady
commented
Apr 7, 2023
| return k | ||
| } | ||
|
|
||
| func (vm *VM) StoreChunk(chunk []byte) error { |
There was a problem hiding this comment.
TODO: add async clearing of chunks (store block heights)
patrick-ogrady
commented
Apr 7, 2023
vm/vm.go
Outdated
| @@ -468,6 +478,7 @@ func (vm *VM) Shutdown(ctx context.Context) error { | |||
| } | |||
|
|
|||
| // Shutdown other async VM mechanisms | |||
| vm.chunkManager.Done() | |||
There was a problem hiding this comment.
TODO: stop chunk manager last
|
TONS of SetPreference changes: |
|
Add metric for |
|
Don't re-trigger notify build until async done (disable timer) |
|
Async overhead (~25% + spiky): |
|
Simple example of fast and slow accept: |
patrick-ogrady
changed the title
block.ChunksnanoBlocks
patrick-ogrady
added a commit
that referenced
this pull request
May 11, 2023
* fix last computation in window * add genesis block to cache * nit * init seen data structures earlier * log proposer monitor refresh time * track mempool size * size-based gossip * make NetworkSizeLimit a const * add mode single * nits * port 159 * update DEVNET instructions * add prometheus cmd * update watch TPS * overhaul spam script * don't add potential block to check * check if should build more frequently * lint * add lll exemption * add helpful comment to window calc * fix spam cmd * lint * add more gossip controls * add gossip settings to scripts run * fix cluster shutdown * ensure client does not write concurrently to ws conn * fix flaky startup * avoid submitting duplicate txs * update with new HYPERSDK_VERSION
19 tasks
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #130
ParseBlock,GetBlock,BuildBlock: https://github.com/ava-labs/avalanchego/blob/7d73b59cb4838d304387ea680b9cc4053b72620c/vms/rpcchainvm/vm_server.go#L457-L464throttler-outbound-at-large-alloc-sizeandthrottler-inbound-at-large-alloc-sizeAlternative: only generate root every X blocks