Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pubsub flaky tests #1616

Closed
aaronbuchwald opened this issue Oct 2, 2024 · 4 comments · Fixed by #1762
Closed

Fix pubsub flaky tests #1616

aaronbuchwald opened this issue Oct 2, 2024 · 4 comments · Fixed by #1762
Assignees
Labels

Comments

@aaronbuchwald
Copy link
Collaborator

Removed two instances of t.Skip("FLAKY") in the pubsub package tests #1593

These seem to be causing a CI flake here: https://github.com/ava-labs/hypersdk/actions/runs/11135413552/job/30945383623?pr=1606#step:5:63
Screenshot 2024-10-01 at 21 31 36

The next package that should report test output is the pubsub package, so a deadlock within these tests may explain the failure.

@aaronbuchwald
Copy link
Collaborator Author

@aaronbuchwald
Copy link
Collaborator Author

Running locally on repeat until it fails, it seems to be blocked here:

require.Eventually(
(using a 15s timeout where the test typically takes 7s to run when it succeeds)

@aaronbuchwald
Copy link
Collaborator Author

@aaronbuchwald
Copy link
Collaborator Author

Got the test output we were looking for here: https://github.com/ava-labs/hypersdk/actions/runs/11149409503/job/30988235110#step:5:62

The unit tests typically take 3 minutes and this times out after 6 minutes

@tsachiherman tsachiherman self-assigned this Nov 4, 2024
@tsachiherman tsachiherman linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants