fix: use avalanchego new *test packages
#620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
changed the title
avalanchego new validatorstest packageavalanchego new *test packages
ceyonur
approved these changes
Aug 6, 2024
Yup. IMO there should never be test-helper code in production. The only reason I used tags at the beginning instead of doing this refactor was because they were a quick fix. |
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* fix: use new `statetest` package from AvalancheGo * fix: use new `validatorstest` package from AvalancheGo * chore: stop using deprecated `validatorstest.TestState` * chore: bump `avalanchego` to commit with new test packages * fix: update all `avalanchego/.../*test` usage * fix: `scripts/versions.sh` in line with `go.mod`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
avalanchegowas refactored and is already depending on one of the commits in this branch.How this works
Magic 🧙 Also Find and Replace, but mostly magic.
How this was tested
Existing tests