-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to Unified Bridge, introduce the ICTT bridge #82
Open
meeh0w
wants to merge
12
commits into
main
Choose a base branch
from
feat/unified-bridging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
meeh0w
changed the title
feat: integrate ICTT bridge
feat: migrate to Unified Bridge, introduce the ICTT bridge
Nov 6, 2024
refactor: use @avalabs/bridge-unified for all bridging
meeh0w
force-pushed
the
feat/unified-bridging
branch
from
November 6, 2024 15:03
c6c3a08
to
10f45d4
Compare
gergelylovas
requested changes
Nov 19, 2024
gergelylovas
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@avalabs/bridge-sdk
(in the frontend -- some backend parts need to stay for a while)@avalabs/bridge-unified
(comes in with CTTP, ICTT (erc20-erc20) and Avalanche Bridge integrations)Changes
@avalabs/bridge-sdk
are still left - during the migration phase, some people may have oldBridgeTransaction
s either in progress or completed, but not acknowledged in the UI yet. We may need a schema migration, depending on how the UnifiedBridgeSDK handles BTC tracking.useAvalancheBridge()
/useBtcBridge()
/useEthBridge()
/useUnifiedBridge()
hooks. The olduseBridge()
which previously merged the capabilities of them all is now enough to handle everything.BridgeFormETH
/BridgeFormBTC
/BridgeFormAVAX
orBridgeFormUnified
. TheBridgeForm
got promoted and is used directly byBridge.tsx
page.The new user path
Testing
unified-bridge-cctp
unified-bridge-ictt
unified-bridge-ab-evm
unified-bridge-ab-ava-to-btc
unified-bridge-ab-btc-to-ava
Screenshots:
Feature Flags examples
When Bitcoin -> Avalanche bridge IS disabled
The moment when selected bridge route (Avalanche -> Bitcoin) gets disabled
Screen.Recording.2024-11-06.at.12.23.58.mov
Checklist for the author