From 6d230c4f7c49b678f70c5554ad387393884f2af6 Mon Sep 17 00:00:00 2001 From: Maru Newby Date: Wed, 29 Jan 2025 21:51:44 +0000 Subject: [PATCH] [docker] Silence remaining InvalidDefaultArgInFrom warnings A previous PR added invalid default arguments to silence unwanted docker build warnings, but missed a few values that are used to populated image names. Such values need to be quoted to be effective in silencing the warnings. --- .dockerignore | 4 ++-- tests/antithesis/avalanchego/Dockerfile.workload | 2 +- tests/antithesis/xsvm/Dockerfile.node | 2 +- tests/antithesis/xsvm/Dockerfile.workload | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.dockerignore b/.dockerignore index 3c0dd2fef296..5e5b5f07e9dc 100644 --- a/.dockerignore +++ b/.dockerignore @@ -9,5 +9,5 @@ LICENSE *.md -Dockerfile - +# Ignore all dockerfiles not just the main one +Dockerfile* diff --git a/tests/antithesis/avalanchego/Dockerfile.workload b/tests/antithesis/avalanchego/Dockerfile.workload index e272997ab4e3..a31099193b6a 100644 --- a/tests/antithesis/avalanchego/Dockerfile.workload +++ b/tests/antithesis/avalanchego/Dockerfile.workload @@ -2,7 +2,7 @@ ARG BUILDER_IMAGE_TAG=INVALID # This value isn't intended to be used but silences a warning # AVALANCHEGO_NODE_IMAGE needs to identify an existing node image and should include the tag -ARG AVALANCHEGO_NODE_IMAGE=INVALID # This value isn't intended to be used but silences a warning +ARG AVALANCHEGO_NODE_IMAGE="invalid-image" # This value isn't intended to be used but silences a warning # ============= Compilation Stage ================ FROM antithesis-avalanchego-builder:$BUILDER_IMAGE_TAG AS builder diff --git a/tests/antithesis/xsvm/Dockerfile.node b/tests/antithesis/xsvm/Dockerfile.node index e21ecf2885c2..313aa2d3934c 100644 --- a/tests/antithesis/xsvm/Dockerfile.node +++ b/tests/antithesis/xsvm/Dockerfile.node @@ -2,7 +2,7 @@ ARG BUILDER_IMAGE_TAG=INVALID # This value isn't intended to be used but silences a warning # AVALANCHEGO_NODE_IMAGE needs to identify an existing avalanchego node image and should include the tag -ARG AVALANCHEGO_NODE_IMAGE=INVALID # This value isn't intended to be used but silences a warning +ARG AVALANCHEGO_NODE_IMAGE="invalid-image" # This value isn't intended to be used but silences a warning # ============= Compilation Stage ================ FROM antithesis-avalanchego-builder:$BUILDER_IMAGE_TAG AS builder diff --git a/tests/antithesis/xsvm/Dockerfile.workload b/tests/antithesis/xsvm/Dockerfile.workload index 2e59d8f40277..90a77d4932d7 100644 --- a/tests/antithesis/xsvm/Dockerfile.workload +++ b/tests/antithesis/xsvm/Dockerfile.workload @@ -2,7 +2,7 @@ ARG BUILDER_IMAGE_TAG=INVALID # This value isn't intended to be used but silences a warning # AVALANCHEGO_NODE_IMAGE needs to identify an existing node image and should include the tag -ARG AVALANCHEGO_NODE_IMAGE=INVALID # This value isn't intended to be used but silences a warning +ARG AVALANCHEGO_NODE_IMAGE="invalid-image" # This value isn't intended to be used but silences a warning # ============= Compilation Stage ================ FROM antithesis-avalanchego-builder:$BUILDER_IMAGE_TAG AS builder