Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] Enable bootstrap testing of partial sync #3508

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Oct 31, 2024

Why this should be merged

Previously there were only 2 modes for bootstrap testing - state sync and full sync. This change enables support for partial sync which only processes the history of the P-Chain and is expected to be used by L1 validators.

How this works

Replaced the StateSyncEnabled field in the bootstrap test config with SyncMode and 3 initial values: full-sync, c-chain-state-sync and p-chain-full-sync-only. The value of SyncMode is determined from the set of env vars defined for an avalanchego container.

How this was tested

Add unit tests to validate determination of sync mode.

Need to be documented in RELEASES.md?

This is not a user facing change.

@marun marun added the testing This primarily focuses on testing label Oct 31, 2024
@marun marun self-assigned this Oct 31, 2024
@marun marun force-pushed the testing-bootstrap-sync-mode branch 4 times, most recently from 724b441 to e5d5cc9 Compare October 31, 2024 16:39
Previously there were only 2 modes for bootstrap testing - state sync
and full sync. This change enables partial sync which only processes
the history of the P-Chain and is expected to be the default mode for
L1 validators.

Rather than adding a new field to the serialized test configuration,
the existing `StateSyncEnabled` field becomes `SyncMode` with 3
values: `full`, `state` and `partial`.
@marun marun force-pushed the testing-bootstrap-sync-mode branch from d8eca22 to a709390 Compare October 31, 2024 17:19
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit 8d22951 Oct 31, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the testing-bootstrap-sync-mode branch October 31, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants