Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify partial sync flag #3505

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

michaelkaplan13
Copy link
Contributor

Why this should be merged

Clarifies that nodes can using the partial-sync-primary-network flag can be L1 validators post-Etna activation.

How this works

Updates documentation.

How this was tested

N/A

Need to be documented in RELEASES.md?

No

Signed-off-by: Michael Kaplan <[email protected]>
config/config.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Kaplan <[email protected]>
config/config.md Outdated
Comment on lines 179 to 181
Partial sync enables nodes that are not primary validators to optionally sync only
the P-chain on the primary network. Nodes that use this option can still track
Subnets. After the Etna upgrade, nodes that use this option can also validate L1s.
Copy link
Contributor

@meaghanfitzgerald meaghanfitzgerald Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Partial sync enables nodes that are not primary validators to optionally sync only
the P-chain on the primary network. Nodes that use this option can still track
Subnets. After the Etna upgrade, nodes that use this option can also validate L1s.
Partial sync enables nodes that do not validate the [Primary Network](https://docs.avax.network/learn/primary-network) to sync only the P-Chain. After the Etna upgrade, nodes that use this option can also sync and/or validate L1s.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phrasing seemed confusing, added a link to the doc that explains the primary network as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they track any Subnets they wouldn't only be syncing the P-Chain though 😅

Copy link
Contributor

@meaghanfitzgerald meaghanfitzgerald Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true 😵‍💫 updated

@StephenButtolph StephenButtolph added the documentation Improvements or additions to documentation or examples label Oct 30, 2024
@StephenButtolph StephenButtolph added this to the v1.11.13 milestone Oct 30, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 2a69d64 Oct 30, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the partial-sync-documentation branch October 30, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation or examples
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants