ACP-77: Add ConversionID to state #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Set the new Subnet manager in the database | ||
| e.State.SetSubnetManager(tx.Subnet, tx.ChainID, tx.Address) | ||
| // Track the subnet conversion in the database | ||
| // TODO: Populate the conversionID |
There was a problem hiding this comment.
Any reason to not calculate the conversion ID here now? Seems somewhat trivial since all the data to calculate is available.
There was a problem hiding this comment.
The SubnetConversionTx changes are in #3397. So those are already pulled out into a separate PR.
michaelkaplan13
approved these changes
Oct 19, 2024
marun
approved these changes
Oct 19, 2024
| @@ -1226,8 +1229,10 @@ platform.getSubnet({ | |||
| a permissioned subnet. If the Subnet is a PoS Subnet, then `threshold` will be `0` and `controlKeys` | |||
| will be empty. | |||
| - changes can not be made into the subnet until `locktime` is in the past. | |||
| - `subnetTransformationTxID` is the ID of the transaction that changed the subnet into a elastic one, | |||
| for when this change was performed. | |||
| - `subnetTransformationTxID` is the ID of the transaction that changed the subnet into an elastic one, if it exists. | |||
There was a problem hiding this comment.
Suggested change
| - `subnetTransformationTxID` is the ID of the transaction that changed the subnet into an elastic one, if it exists. | |
| - `subnetTransformationTxID` is the ID of the transaction that changed the subnet into an L1, if it exists. |
There was a problem hiding this comment.
realized this is probably only referencing the tx hash of TransformSubnetTx can this field not be removed from the response since it has been deprecated?
There was a problem hiding this comment.
I don't think it makes sense to remove this as part of this PR.
marun
approved these changes
Oct 20, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Factored out of #3388.
How this works
Adds the
ConversionIDto theChainIDandAddresspair stored on disk after converting a subnet to an L1.How this was tested