[testing] Double image build timeout for bootstrap monitor e2e #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
bootstrap-monitor-separate-image-builds
branch
from
ce2aabc
to
b46862c
Compare
marun
changed the title
darioush
approved these changes
Oct 12, 2024
yacovm
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Performing the image builds as part of the test suite seemed to provoke OOMkills in CI.Edit: Realized that image builds are actually being killed due to a context with too short a timeout.
How this works
Performs image builds before running suite. The image build to update the hash is still performed by the suite though.Edit: Doubled the timeout
How this was tested
CI