Shrink proposerVM minRecentlyAcceptedWindowSize to 0 #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkaplan13
approved these changes
Oct 3, 2024
StephenButtolph
approved these changes
Oct 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently there's a big wallclock delay between other chains proposer VM heights and P-chain tip. This is an issue for brand new L1s being deployed on Fuji since chain operator needs to wait 16 P-chain blocks before being able to do any interop or warp message signing from their L1.
Additionally messages signed by c-chain are also likely to be invalid for a while if there is any recent change in it's validator set which can happen often during bounty activity.
The issue mostly exists on Fuji right now since there is more frequent block production on the mainnet but this should hopefully be a safe change.
How this works
Shrinks the
minRecentlyAcceptedWindowSizeto 0 andrecentlyAcceptedWindowTLto 30 seconds.How this was tested
CI