Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACP-77: Implement Warp message signing #3428

Merged
merged 706 commits into from
Nov 13, 2024
Merged

ACP-77: Implement Warp message signing #3428

merged 706 commits into from
Nov 13, 2024

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Sep 28, 2024 •
edited
Loading

Why this should be merged

This PR introduces P-Chain warp signing for all the messages that the P-Chain is willing to send to subnet managers according to ACP-77.

How this works

  1. Adds an ACP-118 handler to the P-Chain p2p network.
  2. Implements ACP-118 verification for:
  • SubnetConversion
  • SubnetValidatorRegistration
  • SubnetValidatorWeight

How this was tested

  • Added unit tests for the new verification rules
  • Added E2E tests for each warp message signing

@StephenButtolph StephenButtolph self-assigned this Oct 4, 2024
@StephenButtolph StephenButtolph added this to the v1.12.0-prerelease milestone Oct 4, 2024
@StephenButtolph
fix merge
c7842c0
@StephenButtolph
Merge branch 'implement-acp-77-warp-verification' into implement-acp-…
26aa5a3 
…77-warp-signing
@StephenButtolph
nit
f7c3e71
@StephenButtolph
Merge branch 'add-validation-id-to-wallet' into implement-acp-77-warp…
a245061 
…-verification
@StephenButtolph
Merge branch 'implement-acp-77-warp-verification' into implement-acp-…
ef445ca 
…77-warp-signing
@StephenButtolph
Rename error to be more generic
039d539
@StephenButtolph
Merge branch 'rename-error' into add-get-subnet-only-validator-api
a14dc90
@StephenButtolph
Merge branch 'add-get-subnet-only-validator-api' into add-validation-…
06ce053 
…id-to-wallet
@StephenButtolph
Merge branch 'add-validation-id-to-wallet' into implement-acp-77-warp…
c03ad3b 
…-verification
@StephenButtolph
Merge branch 'implement-acp-77-warp-verification' into implement-acp-…
75f94bf 
…77-warp-signing
@StephenButtolph
Add concurrent reads
e485bd0
@StephenButtolph
Merge branch 'master' into add-get-subnet-only-validator-api
54f58a8
@StephenButtolph
Merge branch 'master' into add-get-subnet-only-validator-api
8806a57
Base automatically changed from implement-acp-77-warp-verification to master November 13, 2024 16:09
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit 6050f16 Nov 13, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the implement-acp-77-warp-signing branch November 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yacovm yacovm yacovm left review comments

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@joshua-kim joshua-kim joshua-kim approved these changes

@ceyonur ceyonur ceyonur approved these changes

@darioush darioush darioush approved these changes

@marun marun marun approved these changes

Assignees

@StephenButtolph StephenButtolph

Labels
acp77
Projects
Platform Engineering Group
Archived in project
Milestone
v1.11.13
Development

Successfully merging this pull request may close these issues.
7 participants
@StephenButtolph @marun @darioush @yacovm @ceyonur @joshua-kim @michaelkaplan13