ACP-77: Implement SetSubnetValidatorWeightTx
#3421
Conversation
…77-sov-validators-state
…cp-77-deactivation
…nt-acp-77-register-subnet-validator-tx
…lement-acp-77--set-subnet-validator-weight-tx
…77-sov-validators-state
…cp-77-deactivation
…nt-acp-77-register-subnet-validator-tx
…lement-acp-77--set-subnet-validator-weight-tx
…lement-acp-77--set-subnet-validator-weight-tx
| currentTimestamp = e.state.GetTimestamp() | ||
| upgrades = e.backend.Config.UpgradeConfig | ||
| ) | ||
| if !upgrades.IsEtnaActivated(currentTimestamp) { |
There was a problem hiding this comment.
I'm not super familiar with the code, but could the:
IsEtnaActivated()
SyntacticVerify()
VerifyMemoFieldLength()
CalculateFee()
VerifySpend()
flow be moved to a helper? Seems to be repeated (or at least close to repeated) for multiple tx types here.
There was a problem hiding this comment.
I do think this can be cleaned up... But I'd prefer it to be done holistically... Since this doesn't really impact correctness, I'm going to merge this PR and treat this as a followup.
There was a problem hiding this comment.
LGTM, just two questions. One if a few of the standard calls for tx verification could be combined in a helper, the other the same as @ceyonur: will SetSubnetValidatorWeightTxs be considered to have the same complexity whether the weight is 0 or not? I guess it would always be charged for the worst case if so?
StephenButtolph
changed the base branch from
master
to
refactor-p-chain-configs
…bnet-validator-weight-tx
StephenButtolph
changed the base branch from
refactor-p-chain-configs
to
refactor-subnet-auth-verification
…7--set-subnet-validator-weight-tx
…7--set-subnet-validator-weight-tx
StephenButtolph
deleted the
implement-acp-77--set-subnet-validator-weight-tx
branch
Why this should be merged
This PR introduces the
SetSubnetValidatorWeightTxdefined by ACP-77.This PR includes:
SetSubnetValidatorWeightTxserialization definitionSetSubnetValidatorWeightTxbuilding and wallet supportSetSubnetValidatorWeightTxSetSubnetValidatorWeightTxSetSubnetValidatorWeightTxThis PR does not include:
SetSubnetValidatorWeightTxHow this works
This PR adds the new
SetSubnetValidatorWeightTxtype and implements all the required visitors.How this was tested