Parsing acp-77 warp payloads #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
changed the title
marun
reviewed
Aug 22, 2024
vms/platformvm/warp/messages/subnet_validator_registration_message.go
Outdated
Show resolved
Hide resolved
I added unit tests for the new package. Until a non-dummy signature request handler is added, I'm not sure how meaningful an E2E or integration test would be. In the meantime, we have incorporated these types and the dummy handler in our E2E testing on the staking contract side. The relevant bit of that testing is that we're able to construct signed Warp messages that contain payloads of these types, and verify them in the smart contract using the Warp precompile. |
marun
reviewed
Aug 22, 2024
StephenButtolph
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds type definitions for the Warp message payloads that the P-Chain signs to implement subnet-only validators, as specified in ACP-77
How this works
Defines the Warp message payload types and registers them with the codec.
How this was tested
CI