Expose upgrade config in the info API #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Aug 2, 2024
| @@ -14,7 +14,7 @@ import ( | |||
|
|
|||
| var ( | |||
| InitiallyActiveTime = time.Date(2020, time.December, 5, 5, 0, 0, 0, time.UTC) | |||
| UnscheduledActivationTime = time.Date(10000, time.December, 1, 0, 0, 0, 0, time.UTC) | |||
| UnscheduledActivationTime = time.Date(9999, time.December, 1, 0, 0, 0, 0, time.UTC) | |||
There was a problem hiding this comment.
JSON marshaling actually doesn't support timestamps with years >9999 because the format is fixed width.
dhrubabasu
approved these changes
Aug 2, 2024
marun
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This will be used in the E2E testing to determine which ruleset should be used when executing tests.
How this works
Exposes the
upgrade.Configthrough a newinfo.upgradesAPI.How this was tested