Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP 118 reference implementation #3218

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Conversation

cam-schultz
Copy link
Contributor

@cam-schultz cam-schultz commented Jul 23, 2024

Why this should be merged

Does not go so far as to add a new package under network/p2p with message parsing, message marshalling, default handlers, etc. ala the gossip package.

How this works

See above

How this was tested

CI

Copy link
Contributor

@michaelkaplan13 michaelkaplan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, would defer to those with more context of the codebase to comment on where the definitions live within the files/packages.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but would be happy to have others review this as well.

network/p2p/handler.go Outdated Show resolved Hide resolved
network/p2p/handler.go Outdated Show resolved Hide resolved
@StephenButtolph
Copy link
Contributor

After adding the couple requested comments - lgtm

@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit 321e727 Jul 26, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the acp-118-reference-impl branch July 26, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants