[antithesis] Add tmpnet support to workloads to simplify development #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
marun
force-pushed
the
antithesis-refactor-workload
branch
from
24c80b1 to
0367e61
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
from
0367e61 to
f6d2bf4
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
from
f6d2bf4 to
8ec0f5d
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
from
8ec0f5d to
4f9746b
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
from
4f9746b to
7c095ec
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
from
7c095ec to
5e26b9d
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
4 times, most recently
from
dbaf205 to
060ddee
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
from
060ddee to
a7ef5ec
Compare
aaronbuchwald
approved these changes
Aug 7, 2024
tests/other_test_context.go
Outdated
Comment on lines
22
to
23
| // TODO(marun) Consider a more descriptive name for this type | ||
| type OtherTestContext struct { |
There was a problem hiding this comment.
optional - seems like renaming this would be worthwhile in this PR
There was a problem hiding this comment.
DefaultTestContext ?
There was a problem hiding this comment.
May be weird because it's not a default so much as, if nothing else (ie not ginkgo) fall back to this, but we typically use ginkgo
There was a problem hiding this comment.
Also not a huge fan of Other... Simple? Fallback? Default?
There was a problem hiding this comment.
NonGinkgo is a bit wordy, Default isn't really true, so Simple it is. 😄
marun
force-pushed
the
antithesis-refactor-workload
branch
2 times, most recently
from
860ad11 to
2a454b2
Compare
StephenButtolph
approved these changes
Aug 13, 2024
tests/other_test_context.go
Outdated
Comment on lines
22
to
23
| // TODO(marun) Consider a more descriptive name for this type | ||
| type OtherTestContext struct { |
There was a problem hiding this comment.
Also not a huge fan of Other... Simple? Fallback? Default?
marun
force-pushed
the
antithesis-refactor-workload
branch
from
2a454b2 to
d65bff9
Compare
marun
force-pushed
the
antithesis-refactor-workload
branch
from
d65bff9 to
b2ea47a
Compare
StephenButtolph
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Iterating on the workload for the avalanchego test setup is simple - just launch a local node. Iterating on the tests for any VM is more complicated due to needing to deploy a subnet and chain. This PR adds tmpnet integration to make iterating on an antithesis workload as simple as iterating on an e2e test.
How this works
log.Fatalfwithrequireand a panic-basedrequire.TestingTto ensure deferred cleanup functions can execute to enable reliable teardown of tmpnet networkslog.Fatalfcallsos.Exitwhich precludes the execution of deferred functionscontext.Background()with a context created withsignal.NotifyContextto support orderly shutdown whenSIGINT(i.e. Ctrl-C) andSIGTERMsignals are receivedHow this was tested
Existing CI, plus added a new sanity check for workloads running with tmpnet
TODO