Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Simplify ci monitoring with custom actions #3161

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Jul 1, 2024

Previously, enabling monitoring of temporary networks for a CI job required duplicating complicated action steps. Encapsulating those steps in a custom action is intended to simplify maintenance and enable direct reuse by other repos (e.g. subnet-evm, hypersdk).

TODO

@marun marun added the ci This focuses on changes to the CI process label Jul 1, 2024
@marun marun self-assigned this Jul 1, 2024
@marun marun force-pushed the ci-monitoring-actions branch 2 times, most recently from ef42cbe to b86900a Compare July 1, 2024 04:39
@marun marun marked this pull request as ready for review July 1, 2024 04:52
Base automatically changed from ci-actionlint to master July 1, 2024 21:18
@marun marun force-pushed the ci-monitoring-actions branch 5 times, most recently from 6ab66ce to ea1b24c Compare July 4, 2024 03:30
@StephenButtolph StephenButtolph added this to the v1.11.10 milestone Jul 4, 2024
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Note that if you get to the point where you'd be using the same action across multiple github repositories, you could create a "common" repository that would host these shared actions.
That's particulary useful when you have a username/password that is stored as part of the repository secrets, and you want to make sure there is only a single "instance" of it.

@marun
Copy link
Contributor Author

marun commented Jul 10, 2024

looks good. Note that if you get to the point where you'd be using the same action across multiple github repositories, you could create a "common" repository that would host these shared actions. That's particulary useful when you have a username/password that is stored as part of the repository secrets, and you want to make sure there is only a single "instance" of it.

It won't actually be necessary to put these actions in a different repo to enable reuse. That's already possible from this repo. I intend to update subnet-evm and hypersdk to use the new actions defined in this PR.

But custom actions don't enable sharing of secrets, as per the example of each invocation of the monitoring action in this PR needing to provide the monitoring secrets. Custom actions are a bit strange in their access to the environment - context values are accessible via input defaults but not directly in steps, and secrets are not accessible at all and need to be provided via inputs.

@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 11, 2024
Merged via the queue into master with commit d71e91b Jul 11, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the ci-monitoring-actions branch July 11, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants