X-chain - introducing fees calculators #2700
Conversation
abi87
force-pushed
the
x-chain_introducing-fees-calculators
branch
12 times, most recently
from
4e0e2f8
to
53df271
Compare
Plan is to introduce dynamic fees as a struct implementing |
| }{ | ||
| { | ||
| name: "BaseTx pre EUpgrade", | ||
| chainTime: preEUpgradeTime, |
There was a problem hiding this comment.
(No action required) Why is this parameter suggested for inclusion in the test case struct if it never varies?
| } | ||
| } | ||
|
|
||
| func baseTx() txs.UnsignedTx { |
There was a problem hiding this comment.
(No action required) Maybe just inline these values given that they aren't used anywhere else?
| @@ -0,0 +1,93 @@ | |||
| // Copyright (C) 2019-2024, Ava Labs, Inc. All rights reserved. | |||
There was a problem hiding this comment.
(No action required) Should this be static_calculator_test.go?
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Why this should be merged
This PR introduced
fees.Calculatorfollowing closely what we have done in theplatformvm.How this works
fee.Calculatorinterface andstaticCalculatorHow this was tested
CI