Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IsCortinaActivated helper #2013

Merged
merged 5 commits into from
Sep 18, 2023
Merged

add IsCortinaActivated helper #2013

merged 5 commits into from
Sep 18, 2023

Conversation

dhrubabasu
Copy link
Contributor

@dhrubabasu dhrubabasu commented Sep 13, 2023

Why this should be merged

makes the Cortina fork check consistent with the prior network upgrade checks

How this works

adds IsCortinaActivated helper and uses it in the delegatee deferral logic.

How this was tested

  • CI
  • Fuji (verify no validators started exactly at CortinaTime)
  • Mainnet (verify no validators started exactly at CortinaTime)

@dhrubabasu dhrubabasu added vm This involves virtual machines cleanup Code quality improvement DO NOT MERGE This PR must not be merged in its current state labels Sep 13, 2023
@dhrubabasu dhrubabasu removed the DO NOT MERGE This PR must not be merged in its current state label Sep 18, 2023
@dhrubabasu
Copy link
Contributor Author

dhrubabasu commented Sep 18, 2023

There are no stakers with StartTime = CortinaTime (tested by syncing both mainnet and fuji with 696ce05)

@StephenButtolph StephenButtolph added this to the v1.10.10 milestone Sep 18, 2023
@StephenButtolph StephenButtolph merged commit abf8194 into dev Sep 18, 2023
@StephenButtolph StephenButtolph deleted the isCortinaActivated branch September 18, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement vm This involves virtual machines
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants