Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve state sync logging #1955

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Improve state sync logging #1955

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
948ba5d
Improve state sync logging
StephenButtolph Sep 3, 2023
29040bd
Merge branch 'dev' into improve-state-sync-logs
StephenButtolph Sep 5, 2023
f606a61
nits
StephenButtolph Sep 5, 2023
50e1a2a
nit
StephenButtolph Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions snow/engine/snowman/syncer/state_syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,27 +233,43 @@ func (ss *stateSyncer) AcceptedStateSummary(ctx context.Context, nodeID ids.Node
// Mark that we received a response from [nodeID]
ss.pendingVoters.Remove(nodeID)

weight := ss.StateSyncBeacons.GetWeight(nodeID)
nodeWeight := ss.StateSyncBeacons.GetWeight(nodeID)
ss.Ctx.Log.Debug("adding weight to summaries",
zap.Stringer("nodeID", nodeID),
zap.Stringers("summaryIDs", summaryIDs),
zap.Uint64("nodeWeight", nodeWeight),
)
for _, summaryID := range summaryIDs {
ws, ok := ss.weightedSummaries[summaryID]
if !ok {
ss.Ctx.Log.Debug("skipping summary",
zap.String("reason", "received a vote from validator for unknown summary"),
zap.String("reason", "unknown summary"),
zap.Stringer("nodeID", nodeID),
zap.Stringer("summaryID", summaryID),
)
continue
}

newWeight, err := math.Add64(weight, ws.weight)
newWeight, err := math.Add64(nodeWeight, ws.weight)
if err != nil {
ss.Ctx.Log.Error("failed to calculate the Accepted votes",
zap.Uint64("weight", weight),
ss.Ctx.Log.Error("failed to calculate new summary weight",
zap.Stringer("nodeID", nodeID),
zap.Stringer("summaryID", summaryID),
zap.Uint64("height", ws.summary.Height()),
zap.Uint64("nodeWeight", nodeWeight),
zap.Uint64("previousWeight", ws.weight),
zap.Error(err),
)
newWeight = stdmath.MaxUint64
}

ss.Ctx.Log.Verbo("updating summary weight",
zap.Stringer("nodeID", nodeID),
zap.Stringer("summaryID", summaryID),
zap.Uint64("height", ws.summary.Height()),
zap.Uint64("previousWeight", ws.weight),
zap.Uint64("newWeight", newWeight),
)
ws.weight = newWeight
}

Expand All @@ -270,6 +286,8 @@ func (ss *stateSyncer) AcceptedStateSummary(ctx context.Context, nodeID ids.Node
if ws.weight < ss.Alpha {
ss.Ctx.Log.Debug("removing summary",
zap.String("reason", "insufficient weight"),
zap.Stringer("summaryID", summaryID),
zap.Uint64("height", ws.summary.Height()),
zap.Uint64("currentWeight", ws.weight),
zap.Uint64("requiredWeight", ss.Alpha),
)
Expand Down