merkledb -- codec nits/cleanup
#1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
commented
Aug 23, 2023
Comment on lines
+251
to
+253
| hasValue := maybeValue.HasValue() | ||
| c.encodeBool(dst, hasValue) | ||
| if hasValue { |
There was a problem hiding this comment.
I think "has value" is simpler than "doesn't not have a value"
danlaine
commented
Aug 23, 2023
| } | ||
|
|
||
| func (c *codecImpl) encodeSerializedPath(s SerializedPath, dst *bytes.Buffer) { | ||
| func (c *codecImpl) encodeSerializedPath(dst *bytes.Buffer, s SerializedPath) { |
There was a problem hiding this comment.
switch parameter order for consistency
darioush
approved these changes
Aug 23, 2023
dhrubabasu
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Code cleanup
How this works
See comments below -- pretty self explanatory
How this was tested
Existing UT