Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merkledb -- codec remove err checks #1899

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Conversation

danlaine
Copy link

Why this should be merged

bytes.Buffer.Write always returns nil so we can remove a bunch of error checks / return values. https://pkg.go.dev/bytes#Buffer.Write

How this works

CTRL + X

How this was tested

Existing UT

@danlaine danlaine added the cleanup Code quality improvement label Aug 23, 2023
@danlaine danlaine self-assigned this Aug 23, 2023
@danlaine danlaine marked this pull request as ready for review August 23, 2023 14:59
@danlaine danlaine merged commit cf6eedc into dev Aug 23, 2023
16 checks passed
@danlaine danlaine deleted the merkledb-codec-remove-err-checks branch August 23, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants