Fix subnet validator set public key initialization #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
bug
StephenButtolph
requested review from
danlaine,
darioush,
dboehm-avalabs,
abi87,
gyuho,
joshua-kim,
hexfusion,
coffeeavax and
ceyonur
as code owners
patrick-ogrady
approved these changes
Aug 9, 2023
hexfusion
approved these changes
Aug 9, 2023
| @@ -2101,6 +2101,129 @@ func TestSubnetValidatorPopulatedToEmptyBLSKeyDiff(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestSubnetValidatorSetAfterPrimaryNetworkValidatorRemoval(t *testing.T) { | |||
…github.com:ava-labs/avalanchego into fix-subnet-validator-set-public-key-initialization
StephenButtolph
deleted the
fix-subnet-validator-set-public-key-initialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves performance regression observed by the Dexalot subnet.
How this works
Rather than erroring during the generation of a subnet's validator set, the public key should be set to
nil.How this was tested
Added an explicit regression test and improved the property testing to cover this case as well.