sync -- add handling for fatal error
#1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 6, 2023 12:57
…o into sync-refactor-client
darioush
approved these changes
Jul 10, 2023
ramilexe
pushed a commit
to ConsiderItDone/avalanchego
that referenced
this pull request
Jul 14, 2023
added 2 commits
August 1, 2023 13:13
dboehm-avalabs
approved these changes
Aug 2, 2023
added 2 commits
August 9, 2023 09:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Failing to send an AppRequest should be treated as fatal (see spec of
SendAppRequest)How this works
Propagate the fatal error up to the sync manager.
How this was tested
Unit test