Continuous Staking 2 - Dropping Pending Validators #1387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
commented
Apr 20, 2023
| // Add allows inserting a transaction in mempool. | ||
| // Timestamp is the chain tip time. It's needed to | ||
| // handle hard forks | ||
| Add(tx *txs.Tx, timestamp time.Time) error |
There was a problem hiding this comment.
Continuous staking fork will change the way txs are stored in mempool. Once activated, there won't be need anymore to distinguish stakers txs and drop those with start time too far ahead in the future.
Currently the easier way to let mempool handle the change in tx classification is to pass chain time at the time Add is called.
Co-authored-by: Dhruba Basu <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Dan Laine <[email protected]> Signed-off-by: Stephen Buttolph <[email protected]> Co-authored-by: Dan Laine <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Co-authored-by: aaronbuchwald <[email protected]>
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
No more pending validators. To add a validator we should specify just its duration, not start/end time anymore. Staking will start as soon as validatorTx is accepted.
How this works
First off, this PR is based off #1530
Its content:
How this was tested
CI + extra UTs for now. Missing fork enabling in testnet and some more e2e tests.