This repository has been archived by the owner on May 14, 2024. It is now read-only.
[pull] master from NixOS:master #12
Open
+52,187
−36,704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
These don't depend on 'man' so we don't need to skip them.
Fix help test in dev shell
Rename InputPath -> InputAttrPath
libstore: Fix progress bars
doc/building: Update for #11799
EvalState::resolveLookupPathPath(): Call resolveSymlinks() before pathExists()
Add a test for #12339
... with nixfmt (rfc style)
Carefully reviewed...
Apply nixfmt
The main improvement is that the new message gives an example of a path that is referenced, which should make it easier to track down. While there, I also clarified the wording, saying exactly why the paths in question were illegal.
Improve "illegal path references in fixed output derivation" error
local-store: fix infinite loop on Windows
It's not very clear what the ownership model is here, but one thing is certain: `.up` can't be destroyed before the StaticEnv that refers to it is. Changing a non-owning pointer to taking shared ownership of the parent `StaticEnv` prevents the `.up` from being freed. I'm not a huge fan of the inverted ownership, where child `StaticEnv` takes a refcount of the parent, but this seems like the least intrusive way to fix the use-after-free. This shouldn't cause any shared_ptr cycles to appear (hopefully).
This is the simplest reproducer I have. It would be great to find a repro without flakes, but I guess this should be ok for now.
Fix perl store bindings
libstore: fix expected bytes in progress bar
This makes it easy to see at a glance what the version of the manual is, e.g. "Nix 2.27.0 Reference Manual".
doc: ssl-cert-file leaks into OSX builds
nix flake archive: Skip relative path inputs
packaging: Use correct stdenv for x86_64-darwin
Include the Nix version in the title of the manual
We can't ignore them entirely, since we do want to archive their transitive inputs. Fixes #12438.
nix flake archive: Recurse into relative path inputs
https://github.com/NixOS/nix/pull/12465/files#r1955286197 > Perhaps that is a misnomer.
Fine-grained access-tokens
Remove {start,stop}ProgressBar()
libstore: fix curl callback function signature
Fix mingw build
2.27 release notes
libexpr: Fix use-after-free of StaticEnv::up
fix: update work meeting calendar link
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )