Add invalid_bundles_undecodeable_tx tests #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
vedhavyas,
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
vedhavyas
reviewed
Nov 26, 2024
NingLin-P
reviewed
Nov 26, 2024
teor2345
force-pushed
the
test-undec-tx
branch
from
d12ef4a
to
cd15f20
Compare
teor2345
force-pushed
the
test-undec-tx
branch
from
cd15f20
to
a5f5eff
Compare
teor2345
force-pushed
the
test-undec-tx
branch
from
a5f5eff
to
4d3783a
Compare
teor2345
commented
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fraud proof tests for undecodable transactions.
I made slightly different changes to the advice in the ticket:
I used a fixed extrinsic code that is currently unused, and added a comment saying we only use it in testsSome extrinsic codes accept any random data after the code, so we can't reliably trigger an undecodable error if we pick those codes at random. The length is usually not correct in random data, but to fail encoding we need to read too many bytes. That gets complicated with compact encoding.
Close #3253.
Code contributor checklist: