Exit with an error if state missing for chosen mapping block #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nazar-pc
reviewed
Nov 25, 2024
| // Similarly, state can be pruned, even if the data is present. | ||
| client | ||
| .runtime_api() | ||
| .extract_block_object_mapping(*best_block_data.block.header().parent_hash(), best_block_data.block.clone()) |
There was a problem hiding this comment.
We already have hash conveniently stored in a variable, no need to re-calculate it again:
Suggested change
| .extract_block_object_mapping(*best_block_data.block.header().parent_hash(), best_block_data.block.clone()) | |
| .extract_block_object_mapping(best_block_to_archive_hash, best_block_data.block.clone()) |
There was a problem hiding this comment.
Technically it’s the hash if the block itself, not the parent block hash?
But in this case, if we haven’t pruned the parent block, we definitely haven’t pruned the block itself.
There was a problem hiding this comment.
I see, I was not reading it correct and you're correct that this change is not equivalent.
nazar-pc
previously approved these changes
Nov 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nazar-pc
force-pushed
the
map-check-state
branch
from
d1b9157 to
46ed466
Compare
nazar-pc
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles an edge case where state is missing for a custom mapping start height:
#3242 (comment)
Code contributor checklist: