Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried for fun, took just a few minutes, but then node failed to compile in CI due to briansmith/ring#2148, which resulted in:
tokio
feature addslibp2p-quic
to dependencies libp2p/rust-libp2p#5629 that causedquic
feature being enabled that in turn pulled old version ofring
among other thingsring
would be pulled in, such that compiles onriscv64gc
without issuesIf at least one of those two were not the case it'd work fine, but as is node fails to compile unfortunately. So it took a bit more than a few minutes overall, but still time well spend IMO as both of reported issues should be fixed regardless.
Code contributor checklist: