-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add council and democracy to consensus runtime #2949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some optional suggestions for making the docs clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a basic setup, I don't have any opinion on the actual parameters though, would be nice if Dariia could take a look
@vedhavyas can you clarify this?
Does this refer to this election? If so, you're right, we don't want that yet. |
@vedhavyas to be able to test this on devnet, can we have voting/enactment period equal to something like 5 min in devnet spec? |
Yes
This should be possible through |
I think genesis config option would be preferred, feature seems fragile, but if we need it as one-off test and remove shortly after than that'll work too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, dk if anyone has comments on the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving after chain spec update
@vedhavyas can we get conflicts resolved and merge this? |
This will likely conflict with #2969 that is about to be merged |
Would be great to get this in today. |
This PR adds Council and Democracy(scope limited, read notes) to consensus runtime.
Council:
Democracy:
For the democracy, at the moment instead of anyone submitting the proposal, the origin is set to any council member. So only a council member can open proposal through democracy directly. This should be changed when we want anyone to submit proposals to democracy.
I have also left TODO for parameters where necessary and also enabled instant execution for democracy. Ideally, in mainnet this Instant execution may not be required.
cc: @dariolina @jfrank-summit @nazar-pc
Please take a look and let me know if you have any questions/concerns
Code contributor checklist: