Use code gen for moshi adapters instead of reflection #673
Conversation
| @@ -20,6 +21,7 @@ internal interface DependencyView<T> : Comparable<T> where T : DependencyView<T> | |||
| * nb: Deliberately does not implement [DependencyView]. For various reasons, this information gets embedded in | |||
| * [ExplodedJar], which is the preferred access point for deeper analysis. | |||
| */ | |||
| @JsonClass(generateAdapter = true) | |||
There was a problem hiding this comment.
This class is also used in serialization but wasn't annotated before, not sure if there's others but they'll need to be updated with this too unless you want to just defensively keep the reflection adapter
There was a problem hiding this comment.
Just in general, why do some additional data classes and enum classes now need this annotation?
There was a problem hiding this comment.
since it's an annotation processor, it needs an annotation to process to know what to generate for. It also ends up being valuable for seeing at-a-glance which classes are relevant for JSON parsing, including enums. It's particularly useful in R8/proguard situations too as there are embedded rules to keep these.
|
I think I got 'em all |
| @@ -8,6 +8,7 @@ plugins { | |||
| id("org.jetbrains.kotlin.jvm") | |||
| `kotlin-dsl` | |||
| groovy | |||
| id("com.google.devtools.ksp") version "1.5.31-1.0.0" | |||
There was a problem hiding this comment.
Would I remove this plugin once this todo was resolved?
// TODO switch to moshi-kotlin-codegen (where this was upstreamed to) once updated to Moshi 1.13.0
There was a problem hiding this comment.
Nope you would just switch the Moshi-KSP dep below with mainline Moshi code gen instead. Though if you can go to kotlin 1.6 in that case, you could replace this with Moshi-IR instead and remove KSP all together
Faster runtime performance plus it should resolve #667 along the way.
Couldn't use moshi-ir due to the low kotlin version here (it only supports Kotlin 1.6+) and lucked out that the first stable version of KSP happened to be the version of Kotlin this uses.