Give advice to change to runtimeOnly where appropriate #646
Conversation
If an advice was computed to change a declaration from 'implementation'/'api' to 'runtimeOnly', this is indeed correct information. The dependency is *not* required at compile time. But it *might* be required at runtime. It is not possible for this plugin to make a clear statement about if it is actually needed at runtime. When getting such an advice, the user might also remove the dependency completely. The 'reason' feature will give more insight on why the dependency *might* be needed at runtime. The following cases are covered: - Contains Service Loader declarations - Contains Security Provider declarations - Contains Content Provider or Service declarations (Android) - Contains Android linters (Lint-Registry entry)
|
I think I'm pretty happy with this. I wonder if we should add this kind of advice to a new section of the report, though, since I know there's a large category of users that will find it confusing. We already do this for But I'm not entirely convinced it's necessary -- I say this to provoke discussion. Thoughts? |
|
I think the separate section is a great idea. Because then the report can clarify that you should change something, but that you can choose between:
How about this? |
This makes it clear that you have the choice between: 1. Change dependency to runtimeOnly 2. Remove dependency completely
Yes! That looks great. Thanks :) |
|
@jjohannes the next thing we need is an update to |
|
Thanks for integrating this!
I wasn't aware. I will have a look and create a follow-up PR. |
If an advice was computed to change a declaration from 'implementation'/'api' to 'runtimeOnly', this is indeed correct
information. The dependency is not required at compile time. But it might be required at runtime.
It is not possible for this plugin to make a clear statement about if it is actually needed at runtime. When getting such an advice, the user might also remove the dependency completely. The 'reason' feature will give more insight on why the dependency might be needed at runtime. The following cases are covered:
Fixes #387