Replace 'artifacts.clear()' with 'isVisible=false' #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjohannes
force-pushed
the
remove-artifacts-clear
branch
from
82dc059 to
e511146
Compare
autonomousapps
approved these changes
Mar 31, 2022
| @@ -8,19 +8,14 @@ import org.gradle.api.Project | |||
| @Suppress("DEPRECATION") // forUseAtConfigurationTime() | |||
| object Flags { | |||
|
|
|||
| internal const val FLAG_CLEAR_ARTIFACTS = "dependency.analysis.clear.artifacts" | |||
There was a problem hiding this comment.
Would you mind leaving these flags here? (removing the methods is fine.) I'm thinking I might like to do a check at some point to let folks know about flags that no longer do anything to help them clean up their builds.
There was a problem hiding this comment.
I reverted this line.
jjohannes
force-pushed
the
remove-artifacts-clear
branch
from
e511146 to
cb99410
Compare
|
You will have to fix the |
This remove the call to 'configurations["archives"].artifacts.clear()'. It is no longer necessary if we set the 'consumable' configuration to 'isVisible = false'. Which this commit does. With this change, we also remove the FLAG_CLEAR_ARTIFACTS and FLAG_SILENT_WARNINGS as these are no longer needed.
jjohannes
force-pushed
the
remove-artifacts-clear
branch
from
cb99410 to
eeeded0
Compare
|
Thanks @mvegter I did not see that test. Very good that it exists. Fixed it. |
|
I also forgot that that test exists! Now I don't need to bother manually testing this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the call to 'configurations["archives"].artifacts.clear()'.
It is no longer necessary if we set the 'consumable' configuration to 'isVisible = false'. Which this commit does.
With this change, we also remove the FLAG_CLEAR_ARTIFACTS and FLAG_SILENT_WARNINGS as these are no longer needed.
Fixes #607