Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of printing duplicate declerations #507

Closed
mvegter opened this issue Oct 14, 2021 · 5 comments
Closed

Allow configuration of printing duplicate declerations #507

mvegter opened this issue Oct 14, 2021 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@mvegter
Copy link
Contributor

mvegter commented Oct 14, 2021

Is your feature request related to a problem? Please describe.

Currently the locateDependencies<VARIANT> are printing duplicate declarations which can be lost in large Gradle projects. This also prevents proper caching of this task as an up-to-date/from-cache is not executing any println's

Describe the solution you'd like

Include the duplicate declarations as a separate category for the projectHealth, which can be configurable to print or not to print.

Describe alternatives you've considered

Additional context

@autonomousapps
Copy link
Owner

Thanks for the request. Could you elaborate on the use case you have for that warning? As you can see, it's never been formalized.

@mvegter
Copy link
Contributor Author

mvegter commented Oct 18, 2021

It is more that we would like to disable it then to actually use it. It produces a lot of noise for us on 'issues' which are not a priority at this time.

@autonomousapps
Copy link
Owner

Got it. I think the most likely direction here would be adding support for another system property. Although since this happens in a task action, a dsl property would also be possible.

@autonomousapps
Copy link
Owner

I think for now I'm just going to disable the warning. Maybe turn it into info-level logging. At least until such time as I have the concept modeled properly (if ever).

@autonomousapps autonomousapps added the enhancement New feature or request label Oct 24, 2021
@autonomousapps autonomousapps added this to the 1.0 milestone Oct 24, 2021
@autonomousapps autonomousapps modified the milestone: 1.0 Nov 1, 2021
@autonomousapps
Copy link
Owner

Resolved via eafc9b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants