Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest that ABI dependencies are unused #500

Conversation

mvegter
Copy link
Contributor

@mvegter mvegter commented Oct 10, 2021

This resolves #501

@mvegter mvegter marked this pull request as ready for review October 10, 2021 12:45
@autonomousapps
Copy link
Owner

Could you file an issue explaining the need for this?

@mvegter mvegter force-pushed the fix/do-not-suggest-that-ABI-dependencies-are-unused branch 5 times, most recently from 1452d5e to 8c8685a Compare October 17, 2021 15:29
@mvegter mvegter force-pushed the fix/do-not-suggest-that-ABI-dependencies-are-unused branch from 8c8685a to 22e0e1c Compare October 18, 2021 06:55
@mvegter mvegter force-pushed the fix/do-not-suggest-that-ABI-dependencies-are-unused branch from 22e0e1c to 1c8777c Compare October 19, 2021 05:19
@GianfrancoMS
Copy link

GianfrancoMS commented Oct 22, 2021

Any updates on this PR?

@autonomousapps
Copy link
Owner

Finally had time to look at this, and found the root cause. Somehow the asm code wasn't tracking interfaces! 😱

I have a simple fix for it, and will steal your spec as a perfect regression test, but I'm not going to take the change to Advisor.kt, as it was more of a band-aid. Much appreciated.

@autonomousapps
Copy link
Owner

Closing as resolved.

@mvegter mvegter deleted the fix/do-not-suggest-that-ABI-dependencies-are-unused branch November 1, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin suggests that ABI dependencies are unused while they are needed for both compile
3 participants