Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native library-only aars always show up as unused #252

Closed
ZacSweers opened this issue Aug 14, 2020 · 4 comments · Fixed by #259
Closed

Native library-only aars always show up as unused #252

ZacSweers opened this issue Aug 14, 2020 · 4 comments · Fixed by #259
Labels
bug Something isn't working
Milestone

Comments

@ZacSweers
Copy link
Contributor

Build scan link

Plugin version
0.56

Gradle version
6.6

Android Gradle Plugin (AGP) version
4.0.1

Describe the bug
Similar to proguard-only artifacts, aars that contain only native library files always are reported as unused

To Reproduce
Steps to reproduce the behavior:

Example aar https://amazon-chime-sdk-android.s3.amazonaws.com/media/0.6.1/amazon-chime-sdk-media-0.6.1.tar.gz

Expected behavior
Unsure if the plugin should try to detect loading native libraries in the aar, but at least not suggesting their removal would be a good start

Additional context

@ZacSweers
Copy link
Contributor Author

The library associated with the above link is amazon chime https://github.com/aws/amazon-chime-sdk-android

@autonomousapps autonomousapps added the bug Something isn't working label Aug 14, 2020
@autonomousapps autonomousapps added this to the 1.0 milestone Aug 14, 2020
@autonomousapps
Copy link
Owner

It might be challenging to determine if libraries such as these are in fact "unused", so I may have to treat them like libraries that include service loaders -- that is, never call them unused.

I'm considering enhancing the reporting so that "whitelisted" dependencies are listed for a human to double-check.

@autonomousapps
Copy link
Owner

@ZacSweers To save me from learning how to use this SDK, can you provide a snippet of sample code that ought to indicate "this is used"? I'd like to write a(n accurate) failing test to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants