Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptimizerSelector:sgd:weight_decay incorrect configuration makes loading fail #22

Open
tomaz-suller opened this issue Aug 15, 2024 · 2 comments

Comments

@tomaz-suller
Copy link

{
"name": "OptimizerSelector:sgd:learning_rate",
"type": "normal_float",
"log": true,
"mu": 0.025,
"sigma": 0.05,
"default": 0.025
},

When trying to execute nasbench301/example.py, I get the following error:

TypeError: NormalFloatHyperparameter.__init__() missing 2 required positional arguments: 'lower' and 'upper'

After some time in the debugger, I found out the issue is in the OptimizerSelector:sgd:weight_decay parameter, which indeed does not have these required attributes, but rather two other (mu and sigma). Should they just be replaced with lower and upper? If not, how should we address this issue?

I tried installing nasbench301 for use in NASLib but this error also appears when trying to load the API from NASLib (as expected since this library isn't working properly).

@milkmilk511
Copy link

I have the same question. How do you solve it?

@tomaz-suller
Copy link
Author

tomaz-suller commented Feb 9, 2025

@milkmilk511 I forked NASLib, nasbench301 and ConfigSpace to apply the necessary fixes myself. Check out https://github.com/tomaz-suller/nasbench301/tree/fix-naslib. If you want to use NASLib, I also have a fix-naslib branch in my fork of that.

With what concerns these parameters, if you're only using the library to query the benchmark and not to train models from scratch (which was my use case), they don't really matter, so I just added some numbers so the config would load properly. They're overwritten anyway by hardcoded values in nasbench301/api.py (or at least they should be, but I also fixed that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants