Create simple example and doc for naive early stopping #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1476 +/- ##
===============================================
- Coverage 84.06% 83.84% -0.23%
===============================================
Files 151 153 +2
Lines 11448 11682 +234
Branches 1988 2039 +51
===============================================
+ Hits 9624 9795 +171
- Misses 1297 1340 +43
- Partials 527 547 +20 |
mfeurer
reviewed
May 16, 2022
|
Hey, are you sure this is ready for review? All tests are failing at the moment. |
|
Github actions was being very weird that day, we'll try try to rerun them and see what happens |
|
Hypothesis was correct, they all passed when I reran them, I also included a test to increase code coverage |
mfeurer
reviewed
Jun 7, 2022
mfeurer
approved these changes
Jun 7, 2022
mfeurer
requested changes
Jun 8, 2022
|
Tests are now failing (I guess due to OpenML), this will have to stall |
mfeurer
approved these changes
Jun 14, 2022
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
* Create simple example and doc for naive early stopping * Fix doc, pass through SMAC callbacks directly * Fix `isinstance` check * Add test for early stopping * Fix signature of early stopping example/test * Fix doc build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the
get_trials_callbackfunctionality a little more and makes it more flexible by only requiring acallableinstead of having to instantiate theSMACcallback object.Should not change existing behaviour as we only wrap the call part and forward the args.