Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVR degree hyperparameter #1308

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix SVR degree hyperparameter #1308

merged 1 commit into from
Nov 17, 2021

Conversation

mfeurer
Copy link
Contributor

@mfeurer mfeurer commented Nov 17, 2021

  • only active if kernel == 'poly'
  • adapt the metadata to reflect this

Fixes issue #1189

* only active if kernel == 'poly'
* adapt the metadata to reflect this
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #1308 (a5d7e48) into development (7364c68) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1308      +/-   ##
===============================================
- Coverage        88.13%   88.07%   -0.07%     
===============================================
  Files              140      140              
  Lines            11163    11163              
===============================================
- Hits              9839     9832       -7     
- Misses            1324     1331       +7     
Impacted Files Coverage Δ
...learn/pipeline/components/regression/libsvm_svr.py 91.46% <100.00%> (ø)
...mponents/feature_preprocessing/nystroem_sampler.py 85.29% <0.00%> (-5.89%) ⬇️
autosklearn/util/logging_.py 88.96% <0.00%> (-1.38%) ⬇️
...ine/components/classification/gradient_boosting.py 93.04% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7364c68...a5d7e48. Read the comment docs.

@eddiebergman eddiebergman changed the base branch from master to development November 17, 2021 13:03
Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this might change some test values as the meta-data is changed, leading to different configurations being used in the warm-start.

@mfeurer mfeurer merged commit 6f13379 into development Nov 17, 2021
@mfeurer mfeurer deleted the fix_1189 branch November 17, 2021 13:39
eddiebergman pushed a commit that referenced this pull request Jan 25, 2022
* only active if kernel == 'poly'
* adapt the metadata to reflect this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants