Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes random_state for make_x from sklearn.datasets #1263

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

eddiebergman
Copy link
Contributor

Fixes a maintenance issue where test_pass_categorical_and_numeric_columns_to_pipeline would occasionally fail, with the cost being slightly higher than the value 0.4 we specified that it should beat.

Fixed the issue by make make_classification deterministic with random_state=0. This was also added to all other sklearn.datasets.make_x present throughout the code base that did not use this.

Also fixes some slight typing issues.

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #1263 (f7ec0b3) into development (502c136) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1263   +/-   ##
============================================
  Coverage        88.09%   88.10%           
============================================
  Files              140      140           
  Lines            11144    11144           
============================================
+ Hits              9817     9818    +1     
+ Misses            1327     1326    -1     
Impacted Files Coverage Δ
autosklearn/estimators.py 93.42% <100.00%> (ø)
autosklearn/util/logging_.py 88.96% <0.00%> (-1.38%) ⬇️
...learn/pipeline/components/regression/libsvm_svr.py 91.46% <0.00%> (+1.21%) ⬆️
...ipeline/components/regression/gradient_boosting.py 93.26% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502c136...f7ec0b3. Read the comment docs.

@eddiebergman eddiebergman changed the title Fixes random_state for make_x from sklearn.datsets Fixes random_state for make_x from sklearn.datasets Oct 5, 2021
@eddiebergman eddiebergman merged commit f899306 into development Nov 3, 2021
@eddiebergman eddiebergman deleted the fix_test_categorical_and_numeric_columns branch November 3, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional test failure test_pass_categorical_and_numeric_columns_to_pipeline[True-numpy]
2 participants