Fixes random_state for make_x from sklearn.datasets #1263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a maintenance issue where
test_pass_categorical_and_numeric_columns_to_pipeline
would occasionally fail, with the cost being slightly higher than the value0.4
we specified that it should beat.Fixed the issue by make
make_classification
deterministic withrandom_state=0
. This was also added to all othersklearn.datasets.make_x
present throughout the code base that did not use this.Also fixes some slight typing issues.
test_pass_categorical_and_numeric_columns_to_pipeline[True-numpy]
#1211