Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Mypy in evaluation (except Train Evaluator) #1077

Merged
merged 5 commits into from
Feb 17, 2021

Conversation

franchuterivera
Copy link
Contributor

This PR enable mypy checking in the evaluation directory of autosklearn.

Train_evaluation is missing due to some mypy complication with the splitters.

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1077 (3eb041f) into development (cf27323) will increase coverage by 0.03%.
The diff coverage is 93.43%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1077      +/-   ##
===============================================
+ Coverage        85.45%   85.49%   +0.03%     
===============================================
  Files              130      130              
  Lines            10330    10365      +35     
===============================================
+ Hits              8828     8862      +34     
- Misses            1502     1503       +1     
Impacted Files Coverage Δ
autosklearn/evaluation/__init__.py 80.76% <86.66%> (+0.41%) ⬆️
autosklearn/evaluation/train_evaluator.py 73.46% <86.95%> (+0.71%) ⬆️
autosklearn/evaluation/abstract_evaluator.py 89.01% <98.30%> (+0.44%) ⬆️
autosklearn/automl.py 84.76% <100.00%> (+0.02%) ⬆️
autosklearn/evaluation/test_evaluator.py 93.75% <100.00%> (+1.15%) ⬆️
autosklearn/evaluation/util.py 100.00% <100.00%> (ø)
...eline/components/feature_preprocessing/fast_ica.py 91.30% <0.00%> (-6.53%) ⬇️
..._preprocessing/select_percentile_classification.py 87.93% <0.00%> (-1.73%) ⬇️
autosklearn/ensemble_builder.py 77.06% <0.00%> (+0.40%) ⬆️
...ature_preprocessing/select_rates_classification.py 87.32% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf27323...e5db241. Read the comment docs.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Train_evaluation is missing due to some mypy complication with the splitters.

Could you please give some more comments here? Could fixing #924 help here?

autosklearn/evaluation/__init__.py Outdated Show resolved Hide resolved
autosklearn/evaluation/__init__.py Outdated Show resolved Hide resolved
autosklearn/evaluation/__init__.py Outdated Show resolved Hide resolved
autosklearn/evaluation/util.py Outdated Show resolved Hide resolved
autosklearn/evaluation/util.py Outdated Show resolved Hide resolved
autosklearn/evaluation/train_evaluator.py Outdated Show resolved Hide resolved
autosklearn/evaluation/train_evaluator.py Outdated Show resolved Hide resolved
autosklearn/evaluation/train_evaluator.py Outdated Show resolved Hide resolved
autosklearn/evaluation/train_evaluator.py Outdated Show resolved Hide resolved
test/test_evaluation/test_train_evaluator.py Show resolved Hide resolved
@mfeurer mfeurer merged commit cda9876 into automl:development Feb 17, 2021
github-actions bot pushed a commit that referenced this pull request Feb 17, 2021
franchuterivera added a commit to franchuterivera/auto-sklearn that referenced this pull request Mar 11, 2021
* MAINT cleanup readme and remove old service yaml file (.landscape.yaml)

* MAINT bump to dev version

* move from fork to spawn

* FIX_1061 (automl#1063)

* FIX_1061

* Fxi type of target

* Moving to classes_

* classes_ should be np.ndarray

* Force float before nan

* Pynisher context is passed to metafeatures (automl#1076)

* Pynisher context to metafeatures

* Update test_smbo.py

Co-authored-by: Matthias Feurer <[email protected]>

* Calculate loss support (automl#1075)

* Calculate loss support

* Relaxed log loss test for individual models

* Feedback from automl#1075

* Missing loss in comment

* Revert back test as well

* Fix rank for metrics for which greater value is not good (automl#1079)

* Enable Mypy in evaluation (except Train Evaluator) (automl#1077)

* Almost all files for evaluation

* Feedback from PR

* Feedback from comments

* Solving rebase artifacts

* Revert bytes

* Automatically update the Copyright when building the html (automl#1074)

* update the year automatically

* Fixes for new numpy

* Revert test

* Prepare new release (automl#1081)

* prepare new release

* fix unit test

* bump version number

* Fix 1072 (automl#1073)

* Improve selector checking

* Remove copy error

* Rebase changes to development

* No .cache and check selector path

* Missing params in signature (automl#1084)

* Add size check before trying to split for GMeans (automl#732)

* Add size check before trying to split

* Rebase to new code

Co-authored-by: chico <[email protected]>

* Fxi broken links in docs and update parallel docs (automl#1088)

* Fxi broken links

* Feedback from comments

* Update manual.rst

Co-authored-by: Matthias Feurer <[email protected]>

* automl#660 Enable Power Transformations Update (automl#1086)

* Power Transformer

* Correct typo

* ADD_630

* PEP8 compliance

* Fix target type

Co-authored-by: MaxGreil <[email protected]>

* Stale Support (automl#1090)

* Stale Support

* Enhanced criteria for stale

* Enable weekly cron job

* test

Co-authored-by: Matthias Feurer <[email protected]>
Co-authored-by: Matthias Feurer <[email protected]>
Co-authored-by: Rohit Agarwal <[email protected]>
Co-authored-by: Pepe Berba <[email protected]>
Co-authored-by: MaxGreil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants