Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cython and numpy build dependencies #519

Closed
adithyabsk opened this issue Jul 26, 2018 · 1 comment
Closed

Remove Cython and numpy build dependencies #519

adithyabsk opened this issue Jul 26, 2018 · 1 comment

Comments

@adithyabsk
Copy link

In order to allow autosklearn to be built without any unnecessary build dependencies and reduce constraints on users, it would make sense to remove these pre-build dependencies. Pull requests #518 and automl/ConfigSpace#82 attempted to resolve this problem. The following links were the sources of the proposed solution.
https://stackoverflow.com/questions/19919905/how-to-bootstrap-numpy-installation-in-setup-py
numpy/numpy#2434
numpy/numpy#432

Upon further testing, I found that although the install worked locally when I would install the package with the implemented changes using "pip install git+[repo]" the installation would fail. I closed the PR because of both this issue and the discovery that using "install_requires" in setup script was discouraged as it uses easy_install instead of pip which don't play nicely together. using pyproject.toml seems to be the correct solution to the chicken and egg problem of build tooling as evidenced though discussions linked below:
pypa/pip#3691
https://github.com/pandas-dev/pandas/pull/16745/files

I would strongly suggest migrating to this standard.

@mfeurer
Copy link
Contributor

mfeurer commented Mar 20, 2019

I believe this was fixed in commit 185170e#diff-2eeaed663bd0d25b7e608891384b7298 via #611. Please reopen if this issue still exists.

@mfeurer mfeurer closed this as completed Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants