Fixes a bug where you had to use ⌘Q twice to quit the mac app. #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebykat
approved these changes
May 14, 2021
There was a problem hiding this comment.
Works great! Tested the build on OSX, I did not test on other platforms but I assume the platform check prevents it from affecting anything else. One note - it might be nice to add a comment for our future selves. The on('before-quit') => shouldQuit = true; bit is something I am 100% not going to understand why it's there in 6 months 😂
Adding in a comment explaining the listener for 'before-quit'
sandymcfadden
force-pushed
the
fix/closing-app-mac-electron
branch
from
a8ebab6 to
0d28813
Compare
|
Good call @codebykat thank you. I've added a comment now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Fixes #2676
In Mac OS there the expected behavior is that when you close the window of an app that it stays running and you can open it again from the dock. Then if you quit the app using ⌘Q it completely closes.
Currently in order to fully quit you need to press ⌘Q twice which is unexpected. This resolves that by allowing you to close the window and reopen it, but also quit the app as expected.
Test
Release