Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for restore deleted tags clarification #2899

Merged

Conversation

sandymcfadden
Copy link
Contributor

Fix

Fixes #2889

With the new restore deleted tags option in the note history revision selector, there was some confusion around what the action would do. This adds a tooltip with more information explaining what will take place.

Screen Shot 2021-05-05 at 9 08 21 AM

Screen Shot 2021-05-05 at 9 07 50 AM

Test

  1. Open a note.
  2. Choose to view its history.
  3. Hover over the new help icon next to Restore deleted tags.
  4. Ensure things look proper.
  5. Ensure the action is clear.

@pachlava
Copy link
Contributor

pachlava commented May 5, 2021

My 2 cents: maybe it's worth making the tooltip opaque, because the revision slider 'line' (and possibly the date value, when the slider is positioned behind the tooltip) make it harder to read the description:

Screenshot 2021-05-05 at 15 24 14

@sandymcfadden sandymcfadden marked this pull request as ready for review May 5, 2021 13:30
@sandymcfadden
Copy link
Contributor Author

Good call @pachlava! I've fixed that up now in my last update.

@sandymcfadden
Copy link
Contributor Author

Going to wait for updated copy from @SylvesterWilmott for this.

@SylvesterWilmott
Copy link
Contributor

For the copy, I think we need something a little more explicit to indicate that it wont restore all tags but only the ones associated with the restored version of the note:

"Any deleted tags associated with the restored version of this note will be re-added to your list of tags."

@sandymcfadden
Copy link
Contributor Author

That does make it more clear @SylvesterWilmott. I've updated the copy to that now

@SylvesterWilmott
Copy link
Contributor

Thanks @sandymcfadden

@sandymcfadden sandymcfadden requested a review from a team May 14, 2021 12:33
@mokagio
Copy link
Contributor

mokagio commented May 14, 2021

Pushing this to 2.12.0 because it's time to finalize 2.11.0 for submission.

@mokagio mokagio modified the milestones: 2.11.0, 2.12.0 May 14, 2021
@mokagio mokagio changed the base branch from release/2.11.0 to develop May 14, 2021 18:55
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in light and dark mode in Firefox and Electron, looks great 👍

Add new help icon
Update to new help icon
Fix positioning of the help icon
Fix background color of tooltips
Update the copy for the added tooltip
@sandymcfadden sandymcfadden force-pushed the add/tooltip-for-restore-deleted-tags-clarification branch from 5123f36 to 37551c6 Compare May 15, 2021 22:40
@sandymcfadden sandymcfadden merged commit 29fe650 into develop May 15, 2021
@sandymcfadden sandymcfadden deleted the add/tooltip-for-restore-deleted-tags-clarification branch May 15, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags are restored regardless of Restore deleted tags state
5 participants